Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Glossary stubs S #3897

Merged
merged 23 commits into from
Aug 15, 2020
Merged

Create Glossary stubs S #3897

merged 23 commits into from
Aug 15, 2020

Conversation

hypercyte
Copy link
Contributor

@hypercyte hypercyte commented Jul 15, 2020 •
edited
Loading

Part of organization effort #3824 #3143

Creates stubs for the following terms:

  • Silence
  • Sampleset
  • Skin
  • Skinner
  • Sliderbreak
  • Slider tick
  • Spectate
  • Spectator Aura (?)
  • Star
  • Star priority
  • Storyboarder

Just made something for everything that didn't already have a stub.

hypercyte added 3 commits July 16, 2020 00:03
@hypercyte
remark fix
419e139
@hypercyte
for real this time
305aa6e
@hypercyte
update silence article
974a87a 
realised i didnt actually finish this one
ubinici
ubinici reviewed Jul 16, 2020
View reviewed changes
Copy link
Contributor

@ubinici ubinici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was just passing by and left a couple of suggestions

wiki/Silence/en.md Outdated Show resolved Hide resolved
wiki/Spectate/en.md Outdated Show resolved Hide resolved
hypercyte and others added 2 commits July 16, 2020 18:15
@hypercyte @ubinici
fix typo
d551c34 
Co-authored-by: Uemit Altar Binici <[email protected]>
@hypercyte @ubinici
osu!direct
fb5879d 
Co-authored-by: Uemit Altar Binici <[email protected]>
MilkyIQ
MilkyIQ reviewed Jul 17, 2020
View reviewed changes
Copy link
Contributor

@MilkyIQ MilkyIQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the slider tick stub, the lack of a stub for that term has been grinding my gears lately 🙏

Pretty good overall, main issue was just formatting. I also made some suggestions that sound better imo, please consider using them.

wiki/Beatmapping/Sampleset/en.md Outdated Show resolved Hide resolved
wiki/Beatmapping/Sampleset/en.md Outdated Show resolved Hide resolved
wiki/Beatmapping/Sampleset/en.md Outdated Show resolved Hide resolved
wiki/Beatmapping/Sampleset/en.md Outdated Show resolved Hide resolved
wiki/Beatmapping/Sampleset/en.md Outdated Show resolved Hide resolved
wiki/Skinning/Skin/en.md Outdated Show resolved Hide resolved
wiki/Skinning/Skin/en.md Outdated Show resolved Hide resolved
wiki/Spectate/en.md Outdated Show resolved Hide resolved
wiki/Spectate/en.md Outdated Show resolved Hide resolved
wiki/Storyboarding/Storyboarder/en.md Outdated Show resolved Hide resolved
MilkyIQ
MilkyIQ reviewed Jul 19, 2020
View reviewed changes
wiki/Silence/en.md Outdated Show resolved Hide resolved
hypercyte and others added 2 commits July 19, 2020 22:05
@hypercyte @MilkyIQ
silence
3ce9925 
Co-authored-by: MilkyIQ <[email protected]>
@hypercyte
remark
e72a000
MilkyIQ
MilkyIQ previously approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@MilkyIQ MilkyIQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

TPGPL
TPGPL previously requested changes Jul 20, 2020
View reviewed changes
wiki/Storyboarding/Storyboarder/en.md Outdated Show resolved Hide resolved
wiki/Star/en.md Outdated Show resolved Hide resolved
wiki/Spectator_aura/en.md Outdated Show resolved Hide resolved
wiki/Spectator_aura/en.md Outdated Show resolved Hide resolved
wiki/Spectate/en.md Outdated Show resolved Hide resolved
wiki/Skinning/Skinner/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Sliderbreak/en.md Show resolved Hide resolved
cl8n
cl8n previously requested changes Jul 20, 2020
View reviewed changes
wiki/Storyboarding/Storyboarder/en.md Outdated Show resolved Hide resolved
wiki/Skinning/Skin/en.md Outdated Show resolved Hide resolved
wiki/Skinning/Skin/en.md Outdated Show resolved Hide resolved
wiki/Skinning/Skinner/en.md Show resolved Hide resolved
@Pennek Pennek mentioned this pull request Jul 22, 2020
Closed
24 tasks
@cl8n cl8n added this to the August 2020 milestone Jul 22, 2020
@MegaApplePi MegaApplePi self-requested a review August 15, 2020 03:00
@MegaApplePi MegaApplePi dismissed stale reviews from cl8n and TPGPL August 15, 2020 03:22

Changes were applied

@MegaApplePi
Copy link
Contributor

SB can probably be added to the list of disambiguation articles

@MegaApplePi MegaApplePi merged commit 90fc91c into ppy:master Aug 15, 2020
@hypercyte hypercyte deleted the glossary-s branch March 1, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubinici ubinici ubinici left review comments

@Pennek Pennek Pennek left review comments

@TPGPL TPGPL TPGPL left review comments

@MegaApplePi MegaApplePi MegaApplePi approved these changes

@MilkyIQ MilkyIQ MilkyIQ left review comments

@cl8n cl8n cl8n left review comments

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
August 2020
Development

Successfully merging this pull request may close these issues.
7 participants
@hypercyte @MegaApplePi @cl8n @TPGPL @Pennek @ubinici @MilkyIQ